chore(code): set billing redirect URL to scroll to phc item#3521
Conversation
|
😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
adboio
added
the
Stamphog
Graphite App
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
stamphog
Bot
removed
the
Stamphog
|
Reviews (1): Last reviewed commit: "chore(code): set billing redirect URL to..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| ): string | null { | ||
| return getPostHogUrl("/organization/billing/overview", regionOverride); | ||
| return getPostHogUrl( | ||
| "/organization/billing/overview?products=posthog_code_usage", |
There was a problem hiding this comment.
The parameterized getBillingUrl tests for US and EU still expect the billing overview URL without this query string. Both cases now receive ?products=posthog_code_usage, so the existing test suite fails until those expectations are updated.
There was a problem hiding this comment.
did i fix them all coach
adboio
added
the
Create Release
Graphite App
dd7d1f0 to
b4640e2
Compare
|
Could not verify team-posthog-code membership (GitHub API error). Auto-release is limited to Team PostHog Code members, so this will ship with the next scheduled release instead. |
3 participants
Problem
all the billing buttons just go to the top of the billing page
it's a confusing page to scroll through
Changes
set query param so the link auto-scrolls to the phc usage based plan section
How did you test this?
manually
Automatic notifications